Dandandan commented on code in PR #11721:
URL: https://github.com/apache/datafusion/pull/11721#discussion_r1696853665
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -104,6 +105,12 @@ impl ApproxPercentileCont {
None
};
+ if args.ignore_nulls {
+ return not_impl_err!(
+ "IGNORE NULLS clause not yet supported for
APPROX_PERCENTILE_CONT"
Review Comment:
Effectively this fix actually does ignore nulls, but we don't have a way to
disable setting RESPECT NULLS.
I believe we should also move DataFusion to `SELECT percentile_cont(0.5)
WITHIN GROUP(order by v)` (used by PostgreSQL, others) syntax...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
