joroKr21 commented on code in PR #21668:
URL: https://github.com/apache/datafusion/pull/21668#discussion_r3264658556
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2495,6 +2495,15 @@ pub struct Filter {
}
impl Filter {
+ /// Create a new filter operator.
+ ///
+ /// Skips the type-checking and dealiasing done in [Self::try_new].
+ /// For internal use in DataFusion only.
+ #[doc(hidden)]
Review Comment:
I think I named it `new` initially, then switched to `new_unchecked` but I
don't have a strong opinion on the name. Makes sense to document the
preconditions 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
