killzoner commented on code in PR #1698:
URL:
https://github.com/apache/datafusion-ballista/pull/1698#discussion_r3264663786
##########
ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs:
##########
@@ -358,6 +371,13 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan>
);
}
}
+
+ if update_pending_tasks_metric {
Review Comment:
Honestly i'm not sure the metric is *that* useful. This accumulates only in
case of no executor being able to launch tasks.
We would probably need to rework the way `bind_schedulable_tasks` is being
done to have a valid and not perf impacting metric.
My take is that it's probably more useful to have a metric saying "no
executor available" than having the number of pending tasks, which is more
focus and also easier to implement (you can probably set this metric only in
`revive_offers`) then *remove* the existing unfilled `pending_tasks_queue_size`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
