milenkovicm commented on code in PR #1726:
URL:
https://github.com/apache/datafusion-ballista/pull/1726#discussion_r3265189688
##########
ballista/scheduler/src/state/mod.rs:
##########
@@ -380,120 +366,20 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerState<T,
job_id: &str,
job_name: &str,
session_ctx: Arc<SessionContext>,
- plan: &LogicalPlan,
+ logical_plan: &LogicalPlan,
queued_at: u64,
subscriber: Option<JobStatusSubscriber>,
) -> Result<()> {
let start = Instant::now();
- let session_config = Arc::new(session_ctx.copied_config());
- if log::max_level() >= log::Level::Debug {
- // optimizing the plan here is redundant because the physical
planner will do this again
- // but it is helpful to see what the optimized plan will be
- let optimized_plan = session_ctx.state().optimize(plan)?;
- debug!("Optimized plan: {}", optimized_plan.display_indent());
- }
-
- let mut explain_inner_logical_plan: Option<Arc<LogicalPlan>> = None;
- plan.apply(&mut |plan: &LogicalPlan| {
- if let LogicalPlan::TableScan(scan) = plan {
- let provider = source_as_provider(&scan.source)?;
- if let Some(table) =
provider.as_any().downcast_ref::<ListingTable>() {
- let local_paths: Vec<&ListingTableUrl> = table
- .table_paths()
- .iter()
- .filter(|url| url.as_str().starts_with("file:///"))
- .collect();
- if !local_paths.is_empty() {
- // These are local files rather than remote object
stores, so we
Review Comment:
yes, i don't think this rule get triggered at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
