timsaucer opened a new pull request, #22368: URL: https://github.com/apache/datafusion/pull/22368
## Which issue does this PR close? Addresses the immediate problem identified in https://github.com/apache/datafusion-python/issues/1551 and the first recommendation in https://github.com/apache/datafusion/issues/22367 ## Rationale for this change We expect Literal and Column expressions and they get `Transform::no` as expected. If we have other PhysicalExpr that similarly should not get through because they have no children then they should likewise get `Transform::no`. This was found when a FFI wrapped Column expression failed in simplification. ## What changes are included in this PR? Essentially a two line change to see if it is a leaf node (no children) instead of just checking that all of the children are literals. ## Are these changes tested? Unit test added. ## Are there any user-facing changes? No user facing changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
