Shekharrajak opened a new issue, #4367:
URL: https://github.com/apache/datafusion-comet/issues/4367

   ### What is the problem the feature request solves?
   
   CometIcebergNativeScanExec.scala  hardcodes outputOrdering to Nil:
   
   ```
   override lazy val outputOrdering: Seq[SortOrder] = Nil
   ```
   
   Ref https://github.com/apache/iceberg/issues/16430
   
   We can update it to : 
   
   ```
   override lazy val outputOrdering: Seq[SortOrder] =
     if (originalPlan != null) originalPlan.outputOrdering else Nil
   ```
   
   originalPlan is the wrapped BatchScanExec. Once Iceberg implements 
SupportsReportOrdering, BatchScanExec.outputOrdering returns the correct sort 
order and Comet inherits it 
   
   This wil eliminate CometSortExec above Iceberg native scans for sort-merge 
joins .
   
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to