asolimando commented on code in PR #21122:
URL: https://github.com/apache/datafusion/pull/21122#discussion_r3269082502
##########
datafusion/common/src/config.rs:
##########
@@ -1131,6 +1131,11 @@ config_namespace! {
/// So if you disable `enable_topk_dynamic_filter_pushdown`, then
enable `enable_dynamic_filter_pushdown`, the
`enable_topk_dynamic_filter_pushdown` will be overridden.
pub enable_dynamic_filter_pushdown: bool, default = true
+ /// When set to true, the pluggable `ExpressionAnalyzerRegistry` from
+ /// `SessionState` is used for expression-level statistics estimation
+ /// (NDV, selectivity, min/max, null fraction) in physical plan
operators.
+ pub use_expression_analyzer: bool, default = false
Review Comment:
As discussed in
https://github.com/apache/datafusion/pull/21122#discussion_r3269047077, I
wanted to make it evident that the new components were totally opt-in and would
not cause any issues for downstream users.
The idea was to later work my way up to a point where this would become the
default mechanism, starting with the same exact behavior by default, and
relying the extensibility of the design to modify it.
Happy to update this PR once https://github.com/apache/datafusion/pull/21815
lands, especially since there seems to be consensus that the design is a
promising direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
