comphead commented on code in PR #4368:
URL: https://github.com/apache/datafusion-comet/pull/4368#discussion_r3270377043
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -72,7 +72,9 @@ abstract class CometTestBase
conf.set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)
conf.set("spark.ui.enabled", "false")
conf.set(SQLConf.SHUFFLE_PARTITIONS, 10) // reduce parallelism in tests
- conf.set(SQLConf.ANSI_ENABLED.key, "false")
+ val sparkMajorVersion =
Review Comment:
its to follow defaults, however in future we need to include ansi to the
test `ConfigMatrix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
