kumarUjjawal commented on PR #22361:
URL: https://github.com/apache/datafusion/pull/22361#issuecomment-4496641890
I started with a logical-planning fix: don’t const-fold regex UDFs or regex
operators when the pattern is pathological. That covers the original
regexp_like('x', 'bad_pattern') repro.
During implementation found another path though. Even if logical planning
leaves the regex expression alone, later physical simplification can replace
partition columns with literals.
So something like regexp_like(partition_col,bad_pattern) can become
regexp_like('value', bad_pattern) during file/pruning setup, and then the
physical const evaluator may compile the regex before execution.
So logical-only is not enough. We need a physical-side guard too.
I'm not sure about the churn for a niche corner case.
@neilconway @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
