alamb commented on PR #11694:
URL: https://github.com/apache/datafusion/pull/11694#issuecomment-2258929222

   I played around with this PR a bit (as I think docs are quite important) -- 
thanks @Rafferty97  
   
   I found I could fix the link in the docs like this:
   ```rust
           #[doc = "Return a [`ScalarUDF`](datafusion_expr::ScalarUDF) for [`"]
           #[doc = stringify!($UDF)]
           #[doc = "`]"]
           pub fn $NAME() -> std::sync::Arc<datafusion_expr::ScalarUDF> {
   ```
   
   However, then I got warning about documenting private items. So I chose to 
just skip the links 
   
   ```
   warning: public documentation for `cardinality_udf` links to private item 
`Cardinality`
     --> datafusion/functions-nested/src/macros.rs:94:21
      |
   94 |               #[doc = concat!("ScalarFunction that returns a 
[`ScalarUDF`](datafusion_expr::ScalarUDF) for [`", stringify!($UDF), "`]")]
      |                       
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
     ::: datafusion/functions-nested/src/cardinality.rs:31:1
      |
   31 | / make_udf_expr_and_func!(
   32 | |     Cardinality,
   33 | |     cardinality,
   34 | |     array,
   35 | |     "returns the total number of elements in the array.",
   36 | |     cardinality_udf
   37 | | );
      | |_- in this macro invocation
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to