zhuqi-lucas commented on code in PR #21976:
URL: https://github.com/apache/datafusion/pull/21976#discussion_r3279276073
##########
datafusion/core/tests/physical_optimizer/enforce_distribution.rs:
##########
@@ -695,17 +695,14 @@ impl TestConfig {
// TODO: End state payloads will be checked here.
}
- for run in optimizers_to_run {
- optimized = match run {
- Run::Distribution => {
- let optimizer = EnforceDistribution::new();
- optimizer.optimize(optimized, &self.config)?
- }
- Run::Sorting => {
- let optimizer = EnforceSorting::new();
- optimizer.optimize(optimized, &self.config)?
- }
- };
+ // With `EnsureRequirements`, distribution and sorting enforcement are
+ // composed into a single idempotent pass, so the historical sequence
+ // of `Run::Distribution` / `Run::Sorting` collapses to repeated calls
+ // of the same rule. The sequences are preserved so existing test
+ // assertions (which encode legacy run orders) remain stable.
Review Comment:
Folded into this PR — f6f8f5a2e. The macro now runs EnsureRequirements
twice (snapshot pass 1, verify pass 2 produces the same plan, sanity-check
both), and the 6 tests that previously called both the macro and
assert_idempotent are down to one call site. Cuts optimizer runs from 3 → 2
per test and means "correct plan + idempotent + sanity" is a single assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
