0lai0 commented on code in PR #4364:
URL: https://github.com/apache/datafusion-comet/pull/4364#discussion_r3279775941
##########
spark/src/main/java/org/apache/comet/vector/CometPlainVector.java:
##########
@@ -143,6 +148,8 @@ public UTF8String getUTF8String(int rowId) {
} else {
return UTF8String.fromString(convertToUuid(result).toString());
}
+ } else {
+ throw new RuntimeException("Unsupported UTF8 vector type: " +
valueVector.getName());
Review Comment:
I looked into this and I don't think this branch is reachable through the
real construction path.
`LargeVarCharVector` is rejected in the `CometDecodedVector` constructor via
`fromArrowType(LargeUtf8)`, before `getUTF8String` can be called.
Supported string vectors use `VarCharVector`, so they take the
`offsetBufferAddress != -1` branch. So I don't think we should add a test for
this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
