manuzhang opened a new pull request, #4386: URL: https://github.com/apache/datafusion-comet/pull/4386
## Which issue does this PR close? N/A. ## Rationale for this change `CometCastSuite` had FloatType, DoubleType, and BinaryType commented out for `ArrayType` to `StringType` casts. The native cast path already handles floating-point elements, and BinaryType can use the existing native binary string formatting path when arrays cast their elements to strings. ## What changes are included in this PR? - Enable FloatType, DoubleType, and BinaryType in `CometCastSuite`.`cast ArrayType to StringType`. - Remove the special incompatibility guard for `ArrayType(BinaryType) -> StringType` so it follows normal element string-cast support. ## How are these changes tested? - `./mvnw test -Pspark-4.1 -Dtest=none -Dsuites="org.apache.comet.CometCastSuite cast ArrayType to StringType"` - Also verified FloatType, DoubleType, and BinaryType one at a time with the same focused Spark 4.1 suite before restoring the full type list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
