chakkk309 commented on PR #22338: URL: https://github.com/apache/datafusion/pull/22338#issuecomment-4514987765
Closing this PR because the underlying panic has been fixed by #22243. I checked current main with the original reproducer from #22223: ```sql SELECT lag(x, -9223372036854775808) OVER (ORDER BY x) FROM (VALUES (1)) AS t(x); ``` It no longer panics and now returns NULL. #22243 also added coverage for extreme lead/lag offsets, including i64::MIN. My PR returned an execution error for this case, while the merged fix treats the offset as out of range and returns the default value or NULL. Since the panic is already handled upstream, this PR is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
