tschwarzinger commented on PR #21714: URL: https://github.com/apache/datafusion/pull/21714#issuecomment-4516590252
As far as I understood it: - This PR adds a mapping from SQL types -> Arrow type + extension type info - #22162 : From what I can tell, this ensures that the extension type information of casts is correct (e.g., casting an extension type to another `DataType` will strip the extension type). Furthermore, it cleans-up some inconsistencies. (Correct me if I am wrong). - #21071 : Introduces the ability to work with the extension type registry in casts. In its full-fledged form, this can include validation support and custom parsing logic. I am not entirely sure what you mean with logical plane and physical plane (logical and physical expression?). I think the "complicated" part of this PR is the handling of casting. One way forward would be to only implement the mapping here and then directly rely on the regular casting machinery for implementing the parsing / validation. With this approach, we could wait until the casting support lands on main and then simply add the mapping here and it should work out-of-the-box. Does that make sense? Right now it seems we are duplicating the extension type casting validation / handling here in the parser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
