andygrove commented on code in PR #4111:
URL: https://github.com/apache/datafusion-comet/pull/4111#discussion_r3289596397
##########
spark/src/test/resources/sql-tests/expressions/string/string_repeat.sql:
##########
@@ -35,3 +35,11 @@ SELECT repeat('hi', n) FROM test_repeat
-- literal + literal
query
SELECT repeat('hi', 3), repeat('', 5), repeat('a', 0), repeat(NULL, 3)
+
+-- non-positive literal count
Review Comment:
can you add non-literal test as well - that does not seem to be covered in
the code change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
