andygrove opened a new pull request, #1754:
URL: https://github.com/apache/datafusion-ballista/pull/1754

   # Which issue does this PR close?
   
   Closes #.
   
   # Rationale for this change
   
   The current \`on:\` block for the Python Release Build workflow has two 
issues.
   
   **1. It runs on every push to a release branch.** \`push: branches: 
[\"branch-*\"]\` triggers a full wheel build on commits, cherry-picks, and 
changelog updates landing on release branches. That's heavy, and a 
release-branch push isn't the canonical event for producing release artifacts — 
the RC tag push is.
   
   **2. It gates tag pushes on a path filter.** The single \`paths: 
[\"python/**\"]\` inside \`push:\` applies to both \`tags:\` and \`branches:\`. 
So an RC tag push currently only triggers the workflow if the tagged commit 
changed \`python/**\`. \`53.0.0-rc1\` happened to trigger only because GitHub's 
\`paths\` filter on tag pushes compares against the previous tag (which 
included python/** changes since the prior release). Relying on that is fragile 
— a release-only commit (changelog, version bump) at the tip of an RC tag could 
silently fail to trigger the wheel build.
   
   # What changes are included in this PR?
   
   \`.github/workflows/build.yml\`: drop \`branches:\` and \`paths:\` from the 
\`push:\` block, leaving only \`tags: [\"*-rc*\"]\`. The pull-request trigger 
is unchanged.
   
   Resulting trigger semantics:
   
   | Event | Fires? |
   | --- | --- |
   | PR that touches \`python/**\` | ✅ (build + test-release only, wheel jobs 
skip on PR per #1749) |
   | PR that doesn't touch \`python/**\` | ❌ |
   | Push of any \`*-rc*\` tag | ✅ (full pipeline incl. wheels, always) |
   | Push to \`branch-*\` | ❌ |
   | Push to \`main\` | ❌ |
   
   # Are there any user-facing changes?
   
   No code changes. CI-only. Release managers should be aware: cutting an RC is 
now the sole trigger for producing release artifacts on the apache repo, and it 
always rebuilds regardless of what the RC commit touched.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to