andygrove opened a new pull request, #1759: URL: https://github.com/apache/datafusion-ballista/pull/1759
# Which issue does this PR close? <!-- no issue filed --> Closes #. # Rationale for this change The Python Release Build's "Source distribution" job runs `maturin build --release --sdist --out dist --strip`. The `maturin build` subcommand produces a wheel even when `--sdist` is passed, so the job ends up emitting both a wheel and the sdist. This trips the "Assert sdist build does not generate wheels" step that was added in #1753, e.g. https://github.com/apache/datafusion-ballista/actions/runs/26345525629/job/77555535891: ``` Error: Sdist build generated wheels: dist/ballista-52.0.0-cp310-abi3-manylinux_2_39_x86_64.whl ``` (The assertion previously looked in `target/wheels` rather than `python/dist`, so the same misbuild silently slipped through.) # What changes are included in this PR? Switch the sdist job's build command to the dedicated `maturin sdist --out dist` subcommand, which only produces a `.tar.gz`. The `--release` and `--strip` flags only apply to wheel builds and are dropped. # Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
