AnuragRaut08 commented on PR #22451: URL: https://github.com/apache/datafusion/pull/22451#issuecomment-4528901010
@jayshrivastava @kosiew — addressed the requested changes: -moved `try_to_proto` into `impl PhysicalExpr for HashTableLookupExpr`so serialization dispatches correctly through the trait object -removed reliance on the centralized downcast serialization path -wired the `proto` feature/dependencies through `datafusion-physical-plan` -updated the serialization comment to explain the pre/post execution cases Validated locally with: -cargo check -p datafusion-physical-plan --features proto` -cargo check -p datafusion-proto` -cargo test -p datafusion-proto roundtrip_hash_table_lookup_expr_to_lit` The roundtrip test now passes through the trait-based serialization path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
