Amogh-2404 commented on PR #22497: URL: https://github.com/apache/datafusion/pull/22497#issuecomment-4530947458
> We have an existing PR for this issue: > > * [fix: make replace empty search string a no-op #22357](https://github.com/apache/datafusion/pull/22357) Thanks @Jefffrey — I missed #22357 when I picked this up, apologies for the duplicate. Happy to close this in favour of it. In case it helps unblock #22357's CI: the cargo test failure looks like the empty-from regression rows in string_query.slt.part still asserting the old output (this PR updates those four rows), and the benchmark failure is likely the benches/replace.rs comment @neilconway mentioned. Glad to help either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
