martin-g commented on code in PR #1760: URL: https://github.com/apache/datafusion-ballista/pull/1760#discussion_r3297945808
########## dev/release/README.md: ########## @@ -203,12 +203,42 @@ For the release to become "official" it needs at least three PMC members to vote ### Verifying Release Candidates -The `dev/release/verify-release-candidate.sh` is a script in this repository that can assist in the verification process. Run it like: +The `dev/release/verify-release-candidate.sh` is a script in this repository that can assist in the verification process. It downloads the source tarball from the ASF dev SVN, verifies the GPG signature and checksums, and builds the Rust workspace. Run it like: ``` ./dev/release/verify-release-candidate.sh 0.11.0 0 ``` +#### (Optional) Verify the Python wheels from TestPyPI + +If the release manager has uploaded the RC's Python wheels to +[test.pypi.org](https://test.pypi.org/project/ballista/) as part of their +pre-vote dry-run (see [Publish Python Wheels to PyPI](#publish-python-wheels-to-pypi) +below), verifiers can install them in a throwaway virtualenv to sanity-check +the artifacts that will ship to real PyPI. The wheels there are byte-identical +to what would be uploaded to pypi.org if the vote passes. + +The wheels are built as `cp310-abi3`, so the venv needs Python ≥ 3.10: + +```bash +export BALLISTA_VERSION=53.0.0 # version under vote + +python3.10 -m venv /tmp/ballista-rc-verify +source /tmp/ballista-rc-verify/bin/activate +pip install -i https://test.pypi.org/simple/ \ + --extra-index-url https://pypi.org/simple/ \ + ballista==${BALLISTA_VERSION} +python -c "from ballista import BallistaSessionContext; print('ok')" +deactivate Review Comment: Is it expected/guaranteed that the new version will be at test.pypi.org ? If the release manager always uploads the wheel to test.pypi.org then this snippet could be added to `dev/release/verify-release-candidate.sh` and done automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
