sp-202 commented on PR #4423:
URL:
https://github.com/apache/datafusion-comet/pull/4423#issuecomment-4535826208
Hi @andygrove — thanks for the clarification, and great to have
@paleolimbot's eyes on this
> To clarify the intent: **this PR is not about accelerating Sedona**. The
goal is to add native geospatial SQL functions directly into Comet the same way
Comet has native math, string, and datetime functions today. No Sedona
dependency, no external library coupling. Comet compiles and runs completely
without Sedona on the classpath.
>
>
> So the core ask of this PR is simply:
> - Users add `CometSparkSessionExtensions` (which they already do to enable
Comet)
> - They get `ST_Contains`, `ST_Intersects`, `ST_Distance` etc. natively in
Spark SQL
> - No Sedona, no extra JARs, no config changes
>
> **On build dependencies** — the native geo layer requires the following
additions to `native/core/Cargo.toml`:
> ```toml
> geo = "0.28"
> geoarrow = "0.8"
> geojson = { version = "0.24", features = ["geo-types"] }
> geos = { version = "8.3", features = ["static"] }
> wkt = "0.11"
> ```
>
> And on the build machine, `libgeos-dev` needs to be installed:
> ```bash
> sudo apt install -y libgeos-dev
> ```
>
> Since `geos` is built with `features = ["static"]`, the GEOS C library is
statically linked into `libcomet.so` — so **end users don't need `libgeos-dev`
at runtime**. The build machine needs it, but the final JAR is self-contained.
For CI, I'm happy to submit a follow-up PR updating the CI workflow once this
PR direction is agreed.
>
I am working on the SQL tests now — will push them shortly. Happy to proceed
however you think is best
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
