goldmedal commented on code in PR #11724:
URL: https://github.com/apache/datafusion/pull/11724#discussion_r1698786265
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2752,11 +2752,10 @@ fn calc_func_dependencies_for_project(
.iter()
.filter_map(|expr| {
let expr_name = match expr {
- Expr::Alias(alias) => {
- format!("{}", alias.expr)
- }
- _ => format!("{}", expr),
- };
+ Expr::Alias(alias) => alias.expr.display_name(),
+ _ => expr.display_name(),
+ }
+ .ok()?;
Review Comment:
I don't know whether this makes sense, but we need a name for the function
dependencies, so I chose a name that wouldn't be affected by Display.
By the way, I'm confused about why we have so many different names or
similar display methods for Expr. Maybe we should organize them or name them
more clearly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
