nanookclaw commented on PR #22284: URL: https://github.com/apache/datafusion/pull/22284#issuecomment-4547947674
I dug into this more after your question, and I agree the original split-out issue looks questionable. What I can verify: - The umbrella report was against DataFusion `53.1.0` / commit `1ab146ad6cc119c7656ae1def75fd40697e5f94a`. - `datafusion/functions/src/regex/regexplike.rs` at that commit already passed non-`g` flags through as inline regex flags (`(?m)`), same as current `main`. - The regexp sqllogictest file at that commit already had multiline regex coverage around the regex operators, and `regexp_like(..., 'm')` flag coverage existed too. - I do not see a later change to `regexplike.rs` that would explain the repro becoming fixed. So my current read is: #22268 was probably a false-positive split from the umbrella issue, or at least not a live `regexp_like` implementation bug by the time this PR was opened. This PR is only regression coverage for the reported PostgreSQL-compatible behavior. If coverage-only is not useful here, I’m fine closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
