martin-g commented on code in PR #1778:
URL:
https://github.com/apache/datafusion-ballista/pull/1778#discussion_r3310629009
##########
ballista/scheduler/src/api/handlers.rs:
##########
@@ -204,8 +205,20 @@ pub struct QueryStageSummary {
#[derive(Debug, serde::Deserialize, Default)]
pub struct JobQueryParams {
- /// Flag to tree-style render for physical plan
- pub render_tree: Option<bool>,
+ /// Controls plan format
+ pub plan_format: Option<PlanFormat>,
+}
+
+#[derive(Debug, serde::Deserialize, Default, Clone)]
+#[serde(rename_all = "snake_case")]
+pub enum PlanFormat {
+ /// ?plan_format=default => plain indent, no metrics
+ #[default]
+ Default,
+ /// ?plan_format=tree => tree render, no metrics
Review Comment:
Please also update the parameter name at
https://github.com/apache/datafusion-ballista/blob/main/ballista-cli/src/tui/http_client.rs#L132
We can add support for `metrics` in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
