neilconway commented on PR #22343: URL: https://github.com/apache/datafusion/pull/22343#issuecomment-4556957603
> I think reordering predicates based on planning time info will suffer from bad statistics (as do all such plan time decisions). If we can figure out some way to make the decision more dynamic I think it will be a better design in the long run / harder to get icnorrectt I agree that doing predicate reordering dynamically has a lot of promise (as well as some potential concerns, like overhead and implementation complexity). But a simple static predicate reordering does not preclude also doing dynamic reordering; indeed, we need _some_ initial predicate order to dynamically adjust later. We already do reorder predicates today, in `simplify_predicates`; this is just a different and I'd say overall slightly better ordering heuristic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
