Sean-Kenneth-Doherty commented on PR #22296: URL: https://github.com/apache/datafusion/pull/22296#issuecomment-4558973622
Addressed the cumulative `List` offset overflow gap in `f395b4eb8`. Changes: - validate the cumulative `output_values_len` against the concrete offset type `O` before value-capacity checks and before fill/mutable buffer allocation - add a two-row `ListArray` regression where each row target fits `i32`, but the combined output length exceeds `i32::MAX` Validation: - `cargo fmt --all --check` - `git diff --check` - `CARGO_BUILD_JOBS=2 cargo test -p datafusion-functions-nested array_resize_rejects_cumulative_list_offset_overflow -- --nocapture` - `CARGO_BUILD_JOBS=2 cargo test -p datafusion-functions-nested array_resize_rejects -- --nocapture` (`2 passed`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
