coderfender commented on code in PR #4111:
URL: https://github.com/apache/datafusion-comet/pull/4111#discussion_r3315419519
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -33,10 +33,6 @@ import
org.apache.comet.serde.QueryPlanSerde.{createBinaryExpr, exprToProtoInter
object CometStringRepeat extends CometExpressionSerde[StringRepeat] {
- override def getCompatibleNotes(): Seq[String] = Seq(
Review Comment:
Interesting.. I did add a test to make sure we are checking for negative
repeat count and it seems to be passing :
https://github.com/apache/datafusion-comet/pull/4111/changes#diff-ac46886742f037b94ca64e4c0422494e7fef8ea954074178ccd9d4398d61980fR41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
