revitalkr commented on code in PR #2355:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2355#discussion_r3317455189
##########
tests/sqlparser_common.rs:
##########
@@ -17449,15 +17448,6 @@ fn join_precedence() {
// canonical string without parentheses
"SELECT * FROM t1 NATURAL JOIN t5 INNER JOIN t0 ON (t0.v1 + t5.v0) > 0
WHERE t0.v1 = t1.v0",
);
- all_dialects_except(|d|
d.supports_left_associative_joins_without_parens()).verified_query_with_canonical(
Review Comment:
It is used for queries with join which is not natural join, currently it's a
snowflake dialect test but I added a test for it in my next PR in the common
file which is using this feature again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
