gabotechs commented on code in PR #22588:
URL: https://github.com/apache/datafusion/pull/22588#discussion_r3317490879


##########
datafusion/functions-nested/src/array_filter.rs:
##########
@@ -91,7 +91,7 @@ impl ArrayFilter {
                 vec![ValueOrLambda::Value(()), ValueOrLambda::Lambda(())],
                 Volatility::Immutable,
             ),
-            aliases: vec![String::from("list_filter")],
+            aliases: vec![String::from("list_filter"), String::from("filter")],

Review Comment:
   These aliases might be a bit to generic and opinionated for them to be 
contributed here. I can imagine how this is very likely to collide with 
something else.
   
   Have you tried just adding this aliases in your own code? registering these 
UDFs with your custom aliases should be trivial.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to