andygrove commented on code in PR #734:
URL: https://github.com/apache/datafusion-comet/pull/734#discussion_r1699195147
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -617,6 +618,136 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("rlike simple case") {
+ val table = "rlike_names"
+ val gen = new DataGenerator(new Random(42))
+ Seq(false, true).foreach { withDictionary =>
+ val data = Seq("James Smith", "Michael Rose", "Rames Rose", "Rames
rose") ++
+ gen.generateStrings(100, "rames Rose", 12)
Review Comment:
@kazuyukitanimura I updated the test and have now added dictionary support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
