alamb commented on issue #21992: URL: https://github.com/apache/datafusion/issues/21992#issuecomment-4564279074
Sounds good -- for the order I would encourage you to start with a .slt test framework and use that to validate end to end behavior For example you could `range_partitioning.slt` create a table with range partitioning using the method like this: https://github.com/apache/datafusion/blob/d4fb7efbbddf3fc02067d6a138bec1d9370101f7/datafusion/sqllogictest/src/test_context.rs#L131-L188 Then start testing with simple things like aggregating on the colums where it it ranged, and not ranged, then jouins, etc I suspect it would make your PRs easier to review / understand what changed if you made an initial one with some basic tests / plans (like `EXPLAIN SELECT ... GROUP BY range_partition_column` and `EXPLAIN SELECT .. GROUP BY non_range_partition`, etc) Then as you go through and implement the feature, your PRs will also demonstrate what is changing / getting better at the end to end sql level -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
