neilconway commented on issue #22583: URL: https://github.com/apache/datafusion/issues/22583#issuecomment-4565166066
Makes sense well enough, although it seems regrettable that we need to add _additional_ work in the case when the optimization fires, just to avoid some work when the optimization doesn't fire. Queries that are expensive to optimize in the first place will almost always have joins, I would expect? I don't have a concrete idea here, but I do wonder whether this (and other "fast-path" optimizer work) is a symptom of an underlying problem -- it should be possible to express tree rewrites in a way where we shouldn't do any copies or tree manipulation if the rewrite doesn't fire. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
