adriangb commented on code in PR #22492:
URL: https://github.com/apache/datafusion/pull/22492#discussion_r3318800863
##########
datafusion/physical-expr/src/expressions/literal.rs:
##########
@@ -133,6 +133,43 @@ impl PhysicalExpr for Literal {
fn placement(&self) -> ExpressionPlacement {
ExpressionPlacement::Literal
}
+
+ #[cfg(feature = "proto")]
+ fn try_to_proto(
+ &self,
+ _ctx:
&datafusion_physical_expr_common::physical_expr::proto_encode::PhysicalExprEncodeCtx<'_>,
+ ) -> Result<Option<datafusion_proto_models::protobuf::PhysicalExprNode>> {
+ use datafusion_proto_models::protobuf;
+ Ok(Some(protobuf::PhysicalExprNode {
+ expr_id: None,
+ expr_type: Some(protobuf::physical_expr_node::ExprType::Literal(
+ self.value().try_into()?,
+ )),
+ }))
+ }
+}
+
+#[cfg(feature = "proto")]
+impl Literal {
+ /// Reconstruct a [`Literal`] from its protobuf representation.
Review Comment:
A single round trip unit test in a test mod like this one would be great:
https://github.com/apache/datafusion/blob/cab69a1d4aa8dab980e468e2ec8089ec66988fce/datafusion/physical-expr/src/expressions/like.rs#L348-L349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
