github-actions[bot] commented on PR #21768: URL: https://github.com/apache/datafusion/pull/21768#issuecomment-4566311184
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 99.357s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.039s] (current) Building datafusion v53.1.0 (baseline) Built [ 99.750s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.905s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 202.929s] datafusion Building datafusion-common v53.1.0 (current) Built [ 33.965s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.063s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 34.763s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.064s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.914s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 71.158s] datafusion-common Building datafusion-expr v53.1.0 (current) Built [ 27.883s] (current) Parsing datafusion-expr v53.1.0 (current) Parsed [ 0.080s] (current) Building datafusion-expr v53.1.0 (baseline) Built [ 27.244s] (baseline) Parsing datafusion-expr v53.1.0 (baseline) Parsed [ 0.079s] (baseline) Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.617s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ExplainOption.show_statistics in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3337 field ExplainOption.analyze_level in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3340 field ExplainOption.analyze_categories in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3343 field ExplainOption.show_statistics in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3337 field ExplainOption.analyze_level in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3340 field ExplainOption.analyze_categories in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3343 field Explain.show_statistics in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3426 field Explain.show_statistics in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3426 field Analyze.analyze_level in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3478 field Analyze.analyze_categories in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3481 field Analyze.analyze_level in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3478 field Analyze.analyze_categories in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:3481 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 58.153s] datafusion-expr Building datafusion-proto v53.1.0 (current) Built [ 60.282s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 59.185s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.347s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 121.744s] datafusion-proto Building datafusion-proto-common v53.1.0 (current) Built [ 21.120s] (current) Parsing datafusion-proto-common v53.1.0 (current) Parsed [ 0.052s] (current) Building datafusion-proto-common v53.1.0 (baseline) Built [ 21.298s] (baseline) Parsing datafusion-proto-common v53.1.0 (baseline) Parsed [ 0.051s] (baseline) Checking datafusion-proto-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.496s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 45.270s] datafusion-proto-common Building datafusion-proto-models v53.1.0 (current) Built [ 24.253s] (current) Parsing datafusion-proto-models v53.1.0 (current) Parsed [ 0.130s] (current) Building datafusion-proto-models v53.1.0 (baseline) Built [ 24.424s] (baseline) Parsing datafusion-proto-models v53.1.0 (baseline) Parsed [ 0.131s] (baseline) Checking datafusion-proto-models v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.164s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ExplainNode.show_statistics in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:369 field ExplainNode.show_statistics in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:369 field AnalyzeNode.analyze_level in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:350 field AnalyzeNode.analyze_categories in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:354 field AnalyzeNode.analyze_level in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:350 field AnalyzeNode.analyze_categories in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:354 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 52.536s] datafusion-proto-models Building datafusion-sql v53.1.0 (current) Built [ 41.473s] (current) Parsing datafusion-sql v53.1.0 (current) Parsed [ 0.032s] (current) Building datafusion-sql v53.1.0 (baseline) Built [ 41.136s] (baseline) Parsing datafusion-sql v53.1.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-sql v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.345s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ExplainStatement.options in /home/runner/work/datafusion/datafusion/datafusion/sql/src/parser.rs:78 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron Failed in: field analyze of struct ExplainStatement, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/c6e6cba3d91640ecc2c48cc0043f289ebc5dcc9b/datafusion/sql/src/parser.rs:65 field verbose of struct ExplainStatement, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/c6e6cba3d91640ecc2c48cc0043f289ebc5dcc9b/datafusion/sql/src/parser.rs:67 field format of struct ExplainStatement, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/c6e6cba3d91640ecc2c48cc0043f289ebc5dcc9b/datafusion/sql/src/parser.rs:69 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 86.145s] datafusion-sql Building datafusion-sqllogictest v53.1.0 (current) Built [ 171.718s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 170.411s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.117s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 346.690s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
