andygrove commented on code in PR #4461:
URL: https://github.com/apache/datafusion-comet/pull/4461#discussion_r3319396501
##########
docs/source/contributor-guide/spark_expressions_support.md:
##########
@@ -523,40 +523,109 @@
### string_funcs
- [x] ascii
+ - Spark 3.4.3 (audited 2026-05-27): identical to 3.5.8.
+ - Spark 3.5.8 (audited 2026-05-27): baseline. `StringType -> IntegerType`;
`nullSafeEval` returns `codePointAt(0)` of the first char, or `0` for the empty
string. Wired via `CometScalarFunction("ascii")` and resolved to DataFusion
`ascii` (`chars().next() as i32`); first-code-point semantics match for ASCII,
BMP, and supplementary code points.
+ - Spark 4.0.1 (audited 2026-05-27): `inputTypes` widened to
`StringTypeWithCollation(supportsTrimCollation = true)`; behaviour unchanged
for `UTF8_BINARY`. Comet does not propagate collation, so non-default
collations may diverge silently.
Review Comment:
Does this documenting, or need an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
