LiaCastaneda commented on PR #22593: URL: https://github.com/apache/datafusion/pull/22593#issuecomment-4566480724
> yep makes sense, I think we can drop the API note here (it was carry over from claude) . About this, I see all the UDF traits follow this struct + inner trait pattern, including the most recent async UDF -- but I think the pattern exists in the first place for backwards compatibility. See #8578 and #8713 (rewrites `ScalarUDF` to wrap `Arc<dyn ScalarUDFImpl>`). The wrapper was kept all along to avoid breaking users of the older API, not because the shape was preferred. I think it's still worth keeping for consistency here, but flagging in case simplifying this across UDFs is something we want to do in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
