adriangb commented on code in PR #21767:
URL: https://github.com/apache/datafusion/pull/21767#discussion_r3320811984


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -3423,13 +3424,17 @@ impl PartialOrd for Explain {
 pub struct Analyze {
     /// Should extra detail be included?
     pub verbose: bool,
+    /// Output syntax/format for the rendered physical plan + metrics.
+    pub format: ExplainFormat,
     /// The logical plan that is being EXPLAIN ANALYZE'd
     pub input: Arc<LogicalPlan>,
     /// The output schema of the explain (2 columns of text)
     pub schema: DFSchemaRef,
 }

Review Comment:
   Fixed both sides:
   - **Logical plan** (`AnalyzeNode`): added `ExplainFormat format = 3` to the 
proto message, regenerated, and wired up encode/decode in `logical_plan/mod.rs`.
   - **Physical plan** (`AnalyzeExecNode`): already done in the previous commit 
— `ExplainFormat format = 7` was added there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to