benbellick commented on PR #22572: URL: https://github.com/apache/datafusion/pull/22572#issuecomment-4575680522
> The idea looks good to me! have not reviewed the implementation though, @benbellick, as our Substrait champion, do you think you can take a look here? @gabotechs 👋 I haven't gotten a chance to take a proper look, but the idea is great. My only concern (which I will have to find as I go into the details) is whether or not we are able to adequately capture the more subtle details of function definitions (e.g. nullability handling, variadic behavior, `any<N>` type parameter binding). It could pose an issue for us if the reported behavior differs from the actual. I will hopefully get to this either today or early next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
