andygrove commented on PR #4514: URL: https://github.com/apache/datafusion-comet/pull/4514#issuecomment-4580561758
> > Thanks @mbutrovich. I went with a different approach of disabling the codegen dispatch for these tests rather than changing the test expectations. Let me know what you think when you have time. > > Hm, assuming the tests checked the query results too I'd prefer to keep the feature enabled, since then we'd just be changing the plan structure checks. Not having dug into the tests, if it's just a plan structure check it's fine to disable the tests. Thanks for the quick response. Ok, will revert to your approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
