schenksj commented on issue #4522: URL: https://github.com/apache/datafusion-comet/issues/4522#issuecomment-4580855734
Closing — this won't be extracted as a standalone PR. The reorder (moving the `hasMetadataCol` reject after the `FileSourceScanExec` case) is **behavior-preserving** for any build without a V1 scan contrib: a V1 metadata-column scan still declines (just inside `transformV1Scan` rather than before it), and V2 is unchanged. So on upstream `main` there is no input that behaves differently before vs. after — it's pure enablement for an optional V1 contrib to intercept metadata-column scans first, with no standalone behavior change to test. Rather than open a core PR that is a no-op on its own, the reorder will land as part of the DataFusion Comet Delta integration PR (the only consumer that gives it meaning), as a focused commit with an equivalence test asserting non-contrib V1 metadata-column scans still decline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
