neilconway commented on PR #22612: URL: https://github.com/apache/datafusion/pull/22612#issuecomment-4583014157
This PR makes sense intuitively, but considering that this PR adds overhead in some cases and improves efficiency in other cases, I wonder if there's a way to quantify the expected win more precisely. The sql_planner benchmark would be an obvious candidate, but it seems that this PR is a win for some cases but a loss for others, and overall slightly slower (although probably within the noise). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
