alamb opened a new pull request, #11763: URL: https://github.com/apache/datafusion/pull/11763
## Which issue does this PR close? Related to https://github.com/apache/datafusion/pull/11723 ## Rationale for this change While working to enable `StringView` by default I hit an error running the [ClickBench "extended" queries](https://github.com/apache/datafusion/blob/feb9100432d453f19d40428265d2aa9a9f942d5d/benchmarks/queries/clickbench/README.md#extended-queries): ``` Finished `release` profile [optimized] target(s) in 0.77s Running `/home/alamb/arrow-datafusion2/target/release/dfbench clickbench --iterations 5 --path /home/alamb/arrow-datafusion/benchmarks/data/hits.par\ quet --queries-path /home/alamb/arrow-datafusion/benchmarks/queries/clickbench/extended.sql -o /home/alamb/arrow-datafusion/benchmarks/results/alamb_stri\ ng_view_default/clickbench_extended.json` Running benchmarks with the following options: RunOpt { query: None, common: CommonOpt { iterations: 5, partitions: None, batch_size: 8192, debug: false \ }, path: "/home/alamb/arrow-datafusion/benchmarks/data/hits.parquet", queries_path: "/home/alamb/arrow-datafusion/benchmarks/queries/clickbench/extended.\ sql", output_path: Some("/home/alamb/arrow-datafusion/benchmarks/results/alamb_string_view_default/clickbench_extended.json") } Q0: SELECT COUNT(DISTINCT "SearchPhrase"), COUNT(DISTINCT "MobilePhone"), COUNT(DISTINCT "MobilePhoneModel") FROM hits; thread 'tokio-runtime-worker' panicked at datafusion/physical-expr-common/src/binary_view_map.rs:220:18: internal error: entered unreachable code: Utf8/Binary should use `ArrowBytesSet` ``` ## What changes are included in this PR? 1. adds unit test coverage for those queries to slt benchmarks 1. Drive by typo fix in README ## Are these changes tested? All tests ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
