nathanb9 commented on PR #21425: URL: https://github.com/apache/datafusion/pull/21425#issuecomment-4584496121
Sorry, I won't be working on this for a bit. Busier than expected @JanKaul From my understanding the big issue with what ive proposed here like @Kontinuation's said: >In DataFusion’s async Volcano model, the control flow is nested within the operators themselves via async streams. This means SortExec and RepartitionExec are coupled in the async poll stack. To me your PRs `tokio::select!` + channel pattern makes a lot more sense. Instead of doing a bunch of nested poll semantics within the main Volcano execution polling... Please ping me if you end up publishing your PR for review. To avoid crowding the Open PR queue I will put this into draft or maybe close it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
