kumarlokesh opened a new pull request, #22656:
URL: https://github.com/apache/datafusion/pull/22656
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #20197.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
`floor(col) = N` is already rewritten via `ScalarUDFImpl::preimage` so that
predicates push into Parquet row-group statistics. `ceil` and `round` admit
the same rewrite but have boundary conventions that don't fit the API's
half-open `[lower, upper)` form: `ceil(x) = N` is `(N-1, N]`, and `round(x)
= N`
is sign-dependent under half-away-from-zero. Both can be expressed in
`[lower, upper)` form by shifting closed boundaries with `f::next_up()`
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- `CeilFunc::preimage` - Float32/Float64 and all four Decimal variants.
- `RoundFunc::preimage` - Float32/Float64 (with optional literal `dp`) and
all
four Decimal variants for `dp = 0`.
- Helper functions `ceil_preimage_float` / `ceil_preimage_decimal` in
`ceil.rs`,
`round_preimage_float` / `round_preimage_decimal` in `round.rs`.
- A small `FloatExt` trait in each file bridging `num_traits::Float` to
`f32::next_up()` / `f64::next_up()`.
No changes to the preimage API, the simplifier, or any optimizer rule.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes.
- Unit tests cover positive / negative / zero / non-integer / null /
overflow /
non-finite cases for both float and decimal variants.
- SLT tests (`ceil_preimage.slt`, `round_preimage.slt`) cover data
correctness
and `EXPLAIN` output for all six comparison operators plus
`IS (NOT) DISTINCT FROM` and `IN`/`NOT IN`.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No public API change. The optimization is transparent and predicate semantics
are preserved exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
