andygrove commented on code in PR #4531:
URL: https://github.com/apache/datafusion-comet/pull/4531#discussion_r3329325051
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -3096,4 +3096,25 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("deep AND/OR predicate chains do not overflow the protobuf recursion
limit") {
Review Comment:
The operands here are never null, so the associativity-with-nulls case is
not exercised. Would it be worth adding a nullable predicate into one of the
chains to lock that in? A deep OR in a WHERE clause might also be worth a case,
since that is a common trigger and stays intact rather than being split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
