schenksj commented on code in PR #4525:
URL: https://github.com/apache/datafusion-comet/pull/4525#discussion_r3329484579
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -728,6 +762,33 @@ case class CometScanTypeChecker() extends DataTypeSupport
with CometTypeShim {
object CometScanRule extends Logging {
+ // Per-scheme memo of `NativeBase.isObjectStoreSchemeSupported`. The answer
depends only on the
+ // URL scheme, so we cache by scheme and never re-cross the JNI boundary for
a repeated scheme.
+ private val schemeSupportCache =
+ new java.util.concurrent.ConcurrentHashMap[String, java.lang.Boolean]()
Review Comment:
Done. Added imports for `java.net.URI`, `java.util.Locale`,
`java.util.concurrent.ConcurrentHashMap`, and `java.lang.Boolean` (aliased
`JBoolean`) and dropped the fully-qualified references. Also fixed a leftover
`withInfo` call in the same code (renamed to `withFallbackReason` in #4508)
that was breaking compilation after merging main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
