Jefffrey commented on issue #2406: URL: https://github.com/apache/datafusion/issues/2406#issuecomment-4591072606
I think there's still some that weren't listed here that still don't support distinct. ## Explicitly denies stddev https://github.com/apache/datafusion/blob/bb121a8fcdb9ca7fa53ee8bcf175844e2a6df7f3/datafusion/functions-aggregate/src/stddev.rs#L118-L123 approx_median https://github.com/apache/datafusion/blob/bb121a8fcdb9ca7fa53ee8bcf175844e2a6df7f3/datafusion/functions-aggregate/src/approx_median.rs#L130-L135 ## May be missing support These functions don't explicitly use the `distinct` flag to handle distinct specific behaviour, but depending on their semantics maybe distinct doesn't make sense for them? Anyway just listing them: - https://github.com/apache/datafusion/blob/bb121a8fcdb9ca7fa53ee8bcf175844e2a6df7f3/datafusion/functions-aggregate/src/regr.rs - https://github.com/apache/datafusion/blob/bb121a8fcdb9ca7fa53ee8bcf175844e2a6df7f3/datafusion/functions-aggregate/src/nth_value.rs - https://github.com/apache/datafusion/blob/bb121a8fcdb9ca7fa53ee8bcf175844e2a6df7f3/datafusion/functions-aggregate/src/covariance.rs - https://github.com/apache/datafusion/blob/bb121a8fcdb9ca7fa53ee8bcf175844e2a6df7f3/datafusion/functions-aggregate/src/correlation.rs - https://github.com/apache/datafusion/blob/bb121a8fcdb9ca7fa53ee8bcf175844e2a6df7f3/datafusion/functions-aggregate/src/approx_percentile_cont.rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
