github-actions[bot] commented on PR #22695: URL: https://github.com/apache/datafusion/pull/22695#issuecomment-4592240387
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 98.482s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v53.1.0 (baseline) Built [ 98.981s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.889s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 200.491s] datafusion Building datafusion-catalog v53.1.0 (current) Built [ 37.382s] (current) Parsing datafusion-catalog v53.1.0 (current) Parsed [ 0.027s] (current) Building datafusion-catalog v53.1.0 (baseline) Built [ 36.873s] (baseline) Parsing datafusion-catalog v53.1.0 (baseline) Parsed [ 0.029s] (baseline) Checking datafusion-catalog v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.176s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 76.043s] datafusion-catalog Building datafusion-cli v53.1.0 (current) Built [ 170.023s] (current) Parsing datafusion-cli v53.1.0 (current) Parsed [ 0.035s] (current) Building datafusion-cli v53.1.0 (baseline) Built [ 168.758s] (baseline) Parsing datafusion-cli v53.1.0 (baseline) Parsed [ 0.041s] (baseline) Checking datafusion-cli v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.144s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 343.230s] datafusion-cli Building datafusion-expr v53.1.0 (current) Built [ 25.454s] (current) Parsing datafusion-expr v53.1.0 (current) Parsed [ 0.078s] (current) Building datafusion-expr v53.1.0 (baseline) Built [ 25.382s] (baseline) Parsing datafusion-expr v53.1.0 (baseline) Parsed [ 0.079s] (baseline) Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.697s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CreateExternalTable.locations in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:219 field CreateExternalTable.locations in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/ddl.rs:219 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron Failed in: field location of struct CreateExternalTable, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/06dd7115d01d285840987edcd0dd32a5798a198a/datafusion/expr/src/logical_plan/ddl.rs:215 field location of struct CreateExternalTable, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/06dd7115d01d285840987edcd0dd32a5798a198a/datafusion/expr/src/logical_plan/ddl.rs:215 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 53.750s] datafusion-expr Building datafusion-ffi v53.1.0 (current) Built [ 57.910s] (current) Parsing datafusion-ffi v53.1.0 (current) Parsed [ 0.061s] (current) Building datafusion-ffi v53.1.0 (baseline) Built [ 57.839s] (baseline) Parsing datafusion-ffi v53.1.0 (baseline) Parsed [ 0.064s] (baseline) Checking datafusion-ffi v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.336s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 117.963s] datafusion-ffi Building datafusion-proto v53.1.0 (current) Built [ 56.273s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 56.793s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.357s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 115.785s] datafusion-proto Building datafusion-proto-models v53.1.0 (current) Built [ 23.632s] (current) Parsing datafusion-proto-models v53.1.0 (current) Parsed [ 0.135s] (current) Building datafusion-proto-models v53.1.0 (baseline) Built [ 23.313s] (baseline) Parsing datafusion-proto-models v53.1.0 (baseline) Parsed [ 0.133s] (baseline) Checking datafusion-proto-models v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.272s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CreateExternalTableNode.locations in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:247 field CreateExternalTableNode.locations in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:247 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron Failed in: field location of struct CreateExternalTableNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/06dd7115d01d285840987edcd0dd32a5798a198a/datafusion/proto-models/src/generated/prost.rs:247 field location of struct CreateExternalTableNode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/06dd7115d01d285840987edcd0dd32a5798a198a/datafusion/proto-models/src/generated/prost.rs:247 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 50.723s] datafusion-proto-models Building datafusion-sql v53.1.0 (current) Built [ 39.938s] (current) Parsing datafusion-sql v53.1.0 (current) Parsed [ 0.034s] (current) Building datafusion-sql v53.1.0 (baseline) Built [ 40.236s] (baseline) Parsing datafusion-sql v53.1.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-sql v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.320s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field CreateExternalTable.locations in /home/runner/work/datafusion/datafusion/datafusion/sql/src/parser.rs:255 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 82.361s] datafusion-sql Building datafusion-sqllogictest v53.1.0 (current) Built [ 169.182s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 169.428s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.108s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 343.592s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
