andygrove opened a new pull request, #4562: URL: https://github.com/apache/datafusion-comet/pull/4562
## Which issue does this PR close? N/A. This adds test coverage only. Surfaces #4560. ## Rationale for this change A sweep of `RuntimeReplaceable` Spark functions found several that Comet already accelerates (they lower to expressions Comet supports) but which had no test coverage guarding that behavior. These tests pin the acceleration so it cannot silently regress. ## What changes are included in this PR? Adds SQL file tests for functions confirmed to run natively in Comet: - `conditional/nullif_zeroif.sql` - `nullifzero`, `zeroifnull` (lower to `if`/`coalesce`). `MinSparkVersion: 4.0`. - `misc/equal_null.sql` - `equal_null` (lowers to `<=>`). - `misc/uniform.sql` - `uniform` with fixed-seed literal args (lowers to `Rand`-based arithmetic). `MinSparkVersion: 4.0`. - `array/array_size.sql` - `array_size` (lowers to `size`). The NULL-array case is `ignore`d pending #4560 (returns -1 instead of NULL). - `array/try_element_at.sql` - `try_element_at` for arrays (lowers to `element_at`); map input falls back (`spark_answer_only`). - `string/to_binary.sql` - `to_binary(x, 'hex')` (lowers to `unhex`); UTF-8/base64 formats fall back (`spark_answer_only`). - `string/collation.sql` - `collation` (folds to a literal). `MinSparkVersion: 4.0`. ## How are these changes tested? This PR is test-only. The files run under `CometSqlFileTestSuite`, executing each query through both Spark and Comet and comparing results; default `query` blocks additionally assert native (non-fallback) execution. Verified locally with `./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite" -Dtest=none`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
